vm: add import assertion support#37176
Merged
+40 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
devsnek added the esm 
cjihrig reviewed Feb 1, 2021
Uh oh!
There was an error while loading. Please reload this page.
devsnekforce-pushed the vm-import-assertion branch from 91e224b to a290d09Compare
addaleax approved these changes Feb 4, 2021
Member
addaleax left a comment
addaleax left a comment There was a problem hiding this comment.
LGTM (with a comment to avoid crashing in cases of prototype pollution addressed)
Uh oh!
There was an error while loading. Please reload this page.
devsnekforce-pushed the vm-import-assertion branch from a290d09 to 4c489f2Comparedevsnekforce-pushed the vm-import-assertion branch from 4c489f2 to d6b0b14Comparedevsnekforce-pushed the vm-import-assertion branch from d6b0b14 to 84cdb17Compare
Collaborator
nodejs-github-bot commented Mar 23, 2021
targos approved these changes Mar 23, 2021
Collaborator
nodejs-github-bot commented Mar 23, 2021
PR-URL: nodejs#37176 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
devsnekforce-pushed the vm-import-assertion branch from 84cdb17 to 26eed3eCompareruyadorno pushed a commit that referenced this pull request Mar 24, 2021
PR-URL: #37176 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Member
ruyadorno commented Mar 30, 2021
hi @devsnek this commit is breaking |
MemberAuthor
devsnek commented Mar 30, 2021
@ruyadorno nope! its stuck to the v8 version in master 😄 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a draft until our V8 is new enough to support this.