timers: remove flaky setInterval test#37227
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
4 tasks
benjamingr approved these changes Feb 4, 2021
Member
benjamingr commented Feb 4, 2021
cc @Trott |
Member
benjamingr commented Feb 4, 2021
👍 to fast track this. |
Collaborator
nodejs-github-bot commented Feb 4, 2021
Member
benjamingr commented Feb 4, 2021
cc @Trott |
aduh95 approved these changes Feb 4, 2021
Collaborator
nodejs-github-bot commented Feb 4, 2021
Collaborator
nodejs-github-bot commented Feb 4, 2021
benjamingr added the fast-track Member
benjamingr commented Feb 4, 2021
Landed in cfb2e06 |
benjamingr pushed a commit that referenced this pull request Feb 4, 2021
PR-URL: #37227 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
PR-URL: #37227 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test added in #37153 relies on an incorrect assumption regarding the timing of setInterval. Since it is causing failures in CI we should remove it until we address the underlying issue to unbreak CI.