repl: assign underscore fix#3737
Uh oh!
There was an error while loading. Please reload this page.
Conversation
There was a problem hiding this comment.
Instead of referring to an issue, how about just explaining why we're doing this.
There was a problem hiding this comment.
Adding here as well.
There was a problem hiding this comment.
+1 to @cjihrig's comment. The reference to the issue is unnecessary, I think.
cjihrig commented Nov 10, 2015
In the docs, where it says |
thefourtheye commented Nov 10, 2015
thefourtheyeforce-pushed the repl-assign-underscore-fix branch from c5273ff to 3d8bb15Comparethefourtheye commented Nov 10, 2015
@cjihrig Updated as per the suggestions. PTAL. |
doc/api/repl.markdown Outdated
There was a problem hiding this comment.
Can you add "the" between "in" and "REPL."
cjihrig commented Nov 10, 2015
A couple small comments, but LGTM. Once the CI is fully available, feel free to squash this and run the tests. |
lib/repl.js Outdated
jasnell commented Nov 12, 2015
LGTM sans a few minor comments. |
jasnell commented Nov 13, 2015
@thefourtheye ... can you please rebase and update? |
thefourtheyeforce-pushed the repl-assign-underscore-fix branch from 63b27a6 to 71fe0a9Compare
As `_` is not defined in REPL's context, when it is defined as `const`, it breaks REPL, as it tries to store the result of the last evaluated expression in `_`. This patch makes sure that `_` is pre-defined in REPL's context, so that if users define it again, they will get error. Refer: nodejs#3729 Refer: nodejs#3704
If the `_` is redefined as `const` in REPL, it will break the REPL, as REPL will store the result of the last evaluated expression in `_`. This patch has a test to make sure that the REPL doesn't allow redefining `_` as `const`, also still assiging values to `_` is permitted. Refer: nodejs#3729 Refer: nodejs#3704
When users assign a value to `_` in REPL, it is prone to unexpected results or messing up with REPL's internals. For example, nodejs#3704. This patch issues a warning about the same.
thefourtheyeforce-pushed the repl-assign-underscore-fix branch from 71fe0a9 to 48d79a4Comparethefourtheye commented Feb 25, 2016
Sorry for the delay. I updated and rebased now. PTAL. |
thefourtheye commented Feb 25, 2016
jasnell commented Mar 2, 2016
LGTM |
jasnell commented Mar 22, 2016
Closing given that #5535 landed. |
5 participants
As
_is not defined in REPL's context, when it is defined asconst,it breaks REPL, as it tries to store the result of the last evaluated
expression in
_. This patch makes sure that_is pre-defined inREPL's context, so that if users define it again, they will get error.
This patch has a test to make sure that the REPL doesn't allow
redefining
_asconst, also still assiging values to_ispermitted.
Refer: #3729
Refer: #3704
cc @jasnell@cjihrig@targos@SamuelMarks@Fishrock123