Skip to content

Conversation

@mhdawson
Copy link
Member

fix alignment of parameters in napi_fatal_error

Signed-off-by: Michael Dawson [email protected]

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 18, 2021
@LxxyxLxxyx added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 18, 2021
fix alignment of parameters in napi_fatal_error Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#37422 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@aduh95
Copy link
Contributor

Landed in f37ae3c

@aduh95aduh95 merged commit f37ae3c into nodejs:masterFeb 22, 2021
targos pushed a commit that referenced this pull request Feb 28, 2021
fix alignment of parameters in napi_fatal_error Signed-off-by: Michael Dawson <[email protected]> PR-URL: #37422 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@targostargos mentioned this pull request Mar 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
fix alignment of parameters in napi_fatal_error Signed-off-by: Michael Dawson <[email protected]> PR-URL: #37422 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@mhdawson@aduh95@Trott@lpinca@richardlau@Lxxyx@marsonya@RaisinTen@nodejs-github-bot