test: remove FLAKY for test-domain-error-types#37458
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
targos approved these changes Feb 20, 2021
Collaborator
nodejs-github-bot commented Feb 20, 2021
lpinca approved these changes Feb 20, 2021
Collaborator
nodejs-github-bot commented Feb 20, 2021
marsonya approved these changes Feb 21, 2021
PR-URL: nodejs#37458 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MemberAuthor
Trott commented Feb 23, 2021
Landed in 32482a8 |
This was referenced Apr 18, 2023
This was referenced Apr 19, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't seem to have failed in the last 2 or 3 days (and probably longer). It was failing in debug builds but there aren't any yellow debug builds in https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_debug_x64/ so this is probably either not an issue anymore or is very rare. (If it's still a problem, we'll want to open an issue for it anyway rather than have it in default-hidden comments in a pull request that's landed.)