doc: add note about tls connection meta data methods#3746
Uh oh!
There was an error while loading. Please reload this page.
Conversation
r-52 added tls 
mscdex commented Nov 10, 2015
When I first read this, I didn't know what methods were being referred to. You might include an example method (e.g. |
DaftMonkforce-pushed the docs-tls-socket branch from 55677f2 to 4ffb9e3Compare
DaftMonk commented Nov 10, 2015
@mscdex Added an example. |
doc/api/tls.markdown Outdated
There was a problem hiding this comment.
Please wrap at 80 columns. Maybe you can turn getPeerCertificate() into a link?
There was a problem hiding this comment.
Updated to use correct column length.
I couldn't get intra-page links working for that section. I tried using the markdown
[getPeerCertificate](#tlssocketgetpeercertificate-detailed-) and when I opened the preview in github and clicked on it, it didn't work. However typing in the url directly https://github.com/DaftMonk/node/blob/docs-tls-socket/doc/api/tls.markdown#tlssocketgetpeercertificate-detailed- did work.
So I'm not sure what the issue was, but I reverted it back to a code example.
There was a problem hiding this comment.
Never mind, I tried again and the link worked this time.
DaftMonkforce-pushed the docs-tls-socket branch 5 times, most recently from 1f04c0b to 0a414e8Compare
DaftMonkforce-pushed the docs-tls-socket branch from 0a414e8 to 66a66d0Compare
bnoordhuis commented Nov 10, 2015
Thanks, landed in eff8c3e. |
PR-URL: #3746 Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: #3746 Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: #3746 Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins commented Nov 17, 2015
landed in v4.x-staging in 8b6120d |
PR-URL: #3746 Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: #3746 Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: #3746 Reviewed-By: Ben Noordhuis <[email protected]>
5 participants
Document current behavior of TLSSocket, as discussed in #3545