Skip to content

Conversation

@jmm
Copy link
Contributor

@jmmjmm commented Nov 10, 2015

Previously this said "see below" to nowhere.

I have the same thing for v4.x.

  1. Another option would be to link to the util.inspect() documentation for all of the options (showHidden|depth|colors) instead of duplicating them (that'd be my preference, unless the build system can accomodate that content being located in one place and inserted in both places in the output).

  2. The task for building the docs depends on building Node? That is prohibitively slow for making docs changes. (I'm doing it where I already have a functioning Node installation.) I had to hack the build scripts to get around that to be able to make these changes, and I wouldn't attempt this again without being able to build them using the existing Node install. It's possible I've misunderstood or done something wrong -- I just followed the instructions from the README: $ make doc.

  3. What does CONTRIBUTING.md mean?:

    The rules for the master branch are less strict;

    Less strict than what?

@Trott
Copy link
Member

I think you want to target the pull request against master rather than v5.x.

@mscdexmscdex added doc Issues and PRs related to the documentations. console Issues and PRs related to the console subsystem. labels Nov 10, 2015
@mikeal
Copy link
Contributor

Everything lands in master and then is cherry-picked into a release branch unless it is for an issues specific to that release line.

@jmmjmmforce-pushed the console-colors-docs-v5 branch from 2cb93ee to db4b07fCompareNovember 10, 2015 21:45
@Fishrock123
Copy link
Contributor

@jmm Could you please open a new Pull Request with the merge base / target set to master? Thanks!

@jmmjmmforce-pushed the console-colors-docs-v5 branch from db4b07f to 2cb93eeCompareNovember 10, 2015 21:51
@jmm
Copy link
ContributorAuthor

jmm commented Nov 10, 2015

Thanks @Trott@mikeal@Fishrock123. I actually saw that (it's right above the part that I linked to), but lost track of it obviously. Sorry about that. I pushed the original commit here again so it's not showing 56 participants anymore (I hope those people didn't get spammed as a result of that...ugh).

@Fishrock123 Opened #3749.

@jmmjmm closed this Nov 10, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consoleIssues and PRs related to the console subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jmm@Trott@mikeal@Fishrock123@mscdex