Skip to content

doc: recommend queueMicrotask over process.nextTick#37484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jasnell wants to merge 1 commit into from
Closed

doc: recommend queueMicrotask over process.nextTick #37484

jasnell wants to merge 1 commit into from

Conversation

@jasnell
Copy link
Member

@jasnelljasnell commented Feb 22, 2021

We likely cannot ever deprecate process.nextTick, but we can start
steering people towards queueMicrotask for most cases.

Signed-off-by: James M Snell [email protected]
Fixes: #36870

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Feb 22, 2021
@jasnelljasnell mentioned this pull request Feb 22, 2021
Closed
mscdex
mscdex reviewed Feb 23, 2021
View reviewed changes
@mscdex
Copy link
Contributor

mscdex commented Feb 23, 2021

I think one obvious (and probably note-worthy) incompatibility compared to process.nextTick() is that you cannot pass values to the callback, something node core takes advantage of extensively for convenience and performance.

@jasnell
Copy link
MemberAuthor

jasnell commented Feb 23, 2021

I think one obvious (and probably note-worthy) incompatibility compared to process.nextTick() is that you cannot pass values to the callback, something node core takes advantage of extensively for convenience and performance.

Good point and definitely worth adding.

@Delapouite
Copy link
Contributor

Delapouite commented Feb 23, 2021

Should queueMicrotask be also mentioned in this documentation page about the event loop: https://nodejs.org/en/docs/guides/event-loop-timers-and-nexttick/ ?

ronag
ronag reviewed Feb 23, 2021
View reviewed changes
@jasnell
doc: recommend queueMicrotask over process.nextTick
02f32c6
We likely cannot ever deprecate process.nextTick, but we can start steering people towards queueMicrotask for most cases. Signed-off-by: James M Snell <[email protected]> Fixes: nodejs#36870
@jasnelljasnellforce-pushed the recommend-queuemicrotask branch from e4c86c3 to 02f32c6CompareFebruary 23, 2021 15:11
@jasnell
Copy link
MemberAuthor

jasnell commented Feb 23, 2021

@Delapouite ... yes, but that's a separate change.

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2021
ronag added a commit to nodejs/undici that referenced this pull request Feb 24, 2021
@ronag
fix: use queueMicrotask
5ca97d6
Fixes: #562 Refs: nodejs/node#37484
martinheidegger
martinheidegger reviewed Feb 24, 2021
View reviewed changes
@jasnell
Copy link
MemberAuthor

jasnell commented Feb 25, 2021

Landed in ee6c467

@jasnelljasnell closed this Feb 25, 2021
jasnell added a commit that referenced this pull request Feb 25, 2021
@jasnell
doc: recommend queueMicrotask over process.nextTick
ee6c467
We likely cannot ever deprecate process.nextTick, but we can start steering people towards queueMicrotask for most cases. Signed-off-by: James M Snell <[email protected]> Fixes: #36870 PR-URL: #37484 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
targos pushed a commit that referenced this pull request Feb 28, 2021
@jasnell@targos
doc: recommend queueMicrotask over process.nextTick
4a40759
We likely cannot ever deprecate process.nextTick, but we can start steering people towards queueMicrotask for most cases. Signed-off-by: James M Snell <[email protected]> Fixes: #36870 PR-URL: #37484 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
@targostargos mentioned this pull request Mar 2, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell@targos
doc: recommend queueMicrotask over process.nextTick
2082f5b
We likely cannot ever deprecate process.nextTick, but we can start steering people towards queueMicrotask for most cases. Signed-off-by: James M Snell <[email protected]> Fixes: #36870 PR-URL: #37484 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronagronagronag approved these changes

@marsonyamarsonyamarsonya approved these changes

+3 more reviewers

@mscdexmscdexmscdex left review comments

@martinheideggermartinheideggermartinheidegger left review comments

@devsnekdevsnekdevsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate process.nextTick in favor of queueMicrotask

8 participants

@jasnell@mscdex@Delapouite@martinheidegger@ronag@devsnek@marsonya@nodejs-github-bot