doc: add url.resolve replacement example#37501
Merged
+18 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
marsonya approved these changes Feb 24, 2021
jasnell approved these changes Feb 24, 2021
aduh95 added the author ready 
RaisinTen approved these changes Feb 25, 2021
Fixes: nodejs#37492 PR-URL: nodejs#37501 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
aduh95force-pushed the url-resolve-whatwg branch from 5bddf51 to 5d240c5CompareContributorAuthor
aduh95 commented Feb 26, 2021
Landed in 5d240c5 |
targos pushed a commit that referenced this pull request Feb 28, 2021
Fixes: #37492 PR-URL: #37501 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
Fixes: #37492 PR-URL: #37501 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #37492