Skip to content

Conversation

@Trott
Copy link
Member

For some reason, the test/addons directory has a status file of
addon.status rather than addons.status. Make it consistent with other
directories.

@nodejs-github-botnodejs-github-bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 27, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
MemberAuthor

Trott commented Mar 1, 2021

Landed in 978594c

Trott added a commit to Trott/io.js that referenced this pull request Mar 1, 2021
For some reason, the test/addons directory has a status file of addon.status rather than addons.status. Make it consistent with other directories. PR-URL: nodejs#37532 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@TrottTrott closed this Mar 1, 2021
@TrottTrott deleted the addons-rename branch March 1, 2021 20:18
lpinca pushed a commit to lpinca/node that referenced this pull request Mar 2, 2021
For some reason, the test/addons directory has a status file of addon.status rather than addons.status. Make it consistent with other directories. PR-URL: nodejs#37532 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Mar 2, 2021
For some reason, the test/addons directory has a status file of addon.status rather than addons.status. Make it consistent with other directories. PR-URL: #37532 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Mar 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
For some reason, the test/addons directory has a status file of addon.status rather than addons.status. Make it consistent with other directories. PR-URL: #37532 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addonsIssues and PRs related to native addons.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@nodejs-github-bot@jasnell@cjihrig@tniessen@richardlau