doc: add localPort to http.request() options#37586
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
Trott reviewed Mar 3, 2021
| avoided. See [`--insecure-http-parser`][] for more information. | ||
| **Default:**`false` | ||
| *`localAddress`{string} Local interface to bind for network connections. | ||
| *`localPort`{number} Local port to connect from. |
MemberAuthor
There was a problem hiding this comment.
It's not a constant. Is "OS selected" ok?
MemberAuthor
There was a problem hiding this comment.
If we add it, I think we should also add it here https://nodejs.org/api/net.html#net_socket_connect_options_connectlistener.
cjihrig approved these changes Mar 3, 2021
marsonya approved these changes Mar 3, 2021
benjamingr approved these changes Mar 10, 2021
Member
benjamingr commented Mar 10, 2021
Landed in 9092afd 🎉 |
benjamingr pushed a commit that referenced this pull request Mar 10, 2021
PR-URL: #37586 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37586 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37586 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentation for the
localPortoption.