Skip to content

Conversation

@Trott
Copy link
Member

@TrottTrott commented Mar 6, 2021

test-stream-pipeline-http2 and test-http2-pipe haven't failed for a long time.

Closes: #20750

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 6, 2021
@TrottTrott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. stream Issues and PRs related to the stream subsystem. windows Issues and PRs related to the Windows platform. labels Mar 6, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
MemberAuthor

Trott commented Mar 8, 2021

@nodejs/testing This could use another review.

Trott added 2 commits March 8, 2021 06:24
It hasn't failed in a long time. Refs: nodejs#20750 PR-URL: nodejs#37631Fixes: nodejs#20750 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
It hasn't failed for a long time. Closes: nodejs#20750 PR-URL: nodejs#37631Fixes: nodejs#20750 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
@TrottTrottforce-pushed the rm-obsolete-flaky branch from cf15eac to f108778CompareMarch 8, 2021 14:24
@TrottTrott merged commit f108778 into nodejs:masterMar 8, 2021
@Trott
Copy link
MemberAuthor

Trott commented Mar 8, 2021

Landed in 8ab6a6c...f108778

@TrottTrott deleted the rm-obsolete-flaky branch March 8, 2021 14:25
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
It hasn't failed in a long time. Refs: #20750 PR-URL: #37631Fixes: #20750 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
It hasn't failed for a long time. Closes: #20750 PR-URL: #37631Fixes: #20750 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
targos pushed a commit that referenced this pull request May 1, 2021
It hasn't failed in a long time. Refs: #20750 PR-URL: #37631Fixes: #20750 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
It hasn't failed for a long time. Closes: #20750 PR-URL: #37631Fixes: #20750 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky-testIssues and PRs related to the tests with unstable failures on the CI.http2Issues or PRs related to the http2 subsystem.needs-ciPRs that need a full CI run.streamIssues and PRs related to the stream subsystem.testIssues and PRs related to the tests.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flaky: parallel/test-http2-* on Windows

4 participants

@Trott@nodejs-github-bot@ruyadorno@targos