Skip to content

doc: fix typo in doc/guides/collaborator-guide.md#37643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marsonya wants to merge 1 commit into from
Closed

doc: fix typo in doc/guides/collaborator-guide.md #37643

marsonya wants to merge 1 commit into from

Conversation

@marsonya
Copy link
Member

@marsonyamarsonya commented Mar 6, 2021

'support' spelled as 'suppport'

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 6, 2021
@PoojaDurgadPoojaDurgad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2021
@benjamingr
Copy link
Member

benjamingr commented Mar 10, 2021

Landed in c347f23 🎉

benjamingr pushed a commit that referenced this pull request Mar 10, 2021
@marsonya@benjamingr
doc: fix typo in doc/guides/collaborator-guide.md
c347f23
PR-URL: #37643 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@marsonya@danielleadams
doc: fix typo in doc/guides/collaborator-guide.md
7c0ce17
PR-URL: #37643 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@marsonya@targos
doc: fix typo in doc/guides/collaborator-guide.md
b0840ac
PR-URL: #37643 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@benjamingrbenjamingrbenjamingr approved these changes

@cjihrigcjihrigcjihrig approved these changes

@tniessentniessentniessen approved these changes

@richardlaurichardlaurichardlau approved these changes

@LxxyxLxxyxLxxyx approved these changes

@ZYSzysZYSzysZYSzys approved these changes

@RaisinTenRaisinTenRaisinTen approved these changes

+1 more reviewer

@PoojaDurgadPoojaDurgadPoojaDurgad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@marsonya@benjamingr@Trott@cjihrig@tniessen@richardlau@Lxxyx@ZYSzys@RaisinTen@PoojaDurgad@nodejs-github-bot