Skip to content

doc: use sentence case in README.md headers#37645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aduh95 merged 1 commit into from
Mar 13, 2021
Merged

doc: use sentence case in README.md headers #37645

aduh95 merged 1 commit into from
Mar 13, 2021

Conversation

@marsonya
Copy link
Member

@marsonyamarsonya commented Mar 6, 2021

changes as per doc styling guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 6, 2021
@marsonyamarsonya changed the title doc: apply use sentence case in README.md headersdoc: use sentence case in README.md headersMar 6, 2021
@marsonya
Copy link
MemberAuthor

marsonya commented Mar 6, 2021

Committed with incorrect message initially.
Commit message now stands amended.

aduh95
aduh95 reviewed Mar 7, 2021
View reviewed changes
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2021
@marsonya@aduh95
doc: use sentence case in README.md headers
b10349a
PR-URL: #37645 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@aduh95
Copy link
Contributor

aduh95 commented Mar 13, 2021

Landed in b10349a

@aduh95aduh95 merged commit b10349a into nodejs:masterMar 13, 2021
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@marsonya@danielleadams
doc: use sentence case in README.md headers
4233d6c
PR-URL: #37645 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
Merged
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@marsonya@danielleadams
doc: use sentence case in README.md headers
e55058f
PR-URL: #37645 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
@marsonya@targos
doc: use sentence case in README.md headers
3a6e405
PR-URL: #37645 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@LxxyxLxxyxLxxyx approved these changes

@aduh95aduh95aduh95 approved these changes

@trivikrtrivikrtrivikr approved these changes

@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@marsonya@aduh95@Trott@Lxxyx@trivikr@RaisinTen@nodejs-github-bot