http: fix double AbortSignal registration#37730
Merged
+143 −17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added http 
Linkgoronforce-pushed the http-fix-double-abort-signal-registration branch from fca3195 to 5e0e0d2Compare
benjamingr approved these changes Mar 12, 2021
aduh95 reviewed Mar 12, 2021
Uh oh!
There was an error while loading. Please reload this page.
Linkgoronforce-pushed the http-fix-double-abort-signal-registration branch 3 times, most recently from 43d4392 to 5fae5afCompareLinkgoronforce-pushed the http-fix-double-abort-signal-registration branch 2 times, most recently from fc42d56 to 38771f4Compare
Collaborator
nodejs-github-bot commented Mar 18, 2021
Collaborator
nodejs-github-bot commented Mar 19, 2021
Linkgoronforce-pushed the http-fix-double-abort-signal-registration branch from 38771f4 to ee27a86CompareCollaborator
nodejs-github-bot commented Mar 19, 2021
Collaborator
nodejs-github-bot commented Mar 20, 2021
Collaborator
nodejs-github-bot commented Mar 20, 2021
Collaborator
nodejs-github-bot commented Mar 20, 2021
Collaborator
nodejs-github-bot commented Mar 20, 2021
Trott approved these changes Mar 20, 2021
Fix an issue where AbortSignals are registered twice PR-URL: nodejs#37730 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Trottforce-pushed the http-fix-double-abort-signal-registration branch from ee27a86 to 711e210Compare
Member
Trott commented Mar 20, 2021
Landed in 711e210 |
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
Fix an issue where AbortSignals are registered twice PR-URL: #37730 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like #36431 added support for AbortSignal to
net.createConnectionandnet.connect(will add tests/docs in a separate PR). This caused "double registration" to the AbortSignal. This PR fixes the issue by removing the signal from the internal calls tonet.Also added tests for http.agent
@benjamingr