test: account for OOM risks in heapsnapshot-near-heap-limit tests#37761
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
MemberAuthor
joyeecheung commented Mar 15, 2021
MemberAuthor
joyeecheung commented Mar 16, 2021
stress test for the worker one: https://ci.nodejs.org/job/node-stress-single-test/226/ |
RaisinTen approved these changes Mar 16, 2021
Collaborator
nodejs-github-bot commented Mar 16, 2021
Member
RaisinTen commented Mar 16, 2021
Nit: Should we use this in the commit message so that the related issue gets closed when this lands? |
marsonya approved these changes Mar 17, 2021
Collaborator
nodejs-github-bot commented Mar 18, 2021
Trott approved these changes Mar 20, 2021
PR-URL: nodejs#37761Fixes: nodejs#36961 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Trott commented Mar 20, 2021
Landed in a41c3e1 |
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
PR-URL: #37761Fixes: #36961 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
targos pushed a commit that referenced this pull request Aug 8, 2021
PR-URL: #37761Fixes: #36961 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Aug 12, 2021
PR-URL: #37761Fixes: #36961 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 31, 2021
PR-URL: #37761Fixes: #36961 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
PR-URL: nodejs#37761Fixes: nodejs#36961 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #36961