test: fix flaky test-vm-timeout-escape-promise-module-2#37842
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Test is reliable in sequential and not in parallel, so move it there. Fixes: nodejs#36627
Trott added the flaky-test 
nodejs-github-bot added needs-ci 
benjamingr approved these changes Mar 20, 2021
aduh95 approved these changes Mar 20, 2021
Collaborator
nodejs-github-bot commented Mar 20, 2021
cjihrig approved these changes Mar 20, 2021
Collaborator
marsonya approved these changes Mar 21, 2021
jasnell approved these changes Mar 22, 2021
jasnell added author ready 
This comment has been minimized.
This comment has been minimized.
Member
jasnell commented Mar 22, 2021
Landed in 341812b |
jasnell pushed a commit that referenced this pull request Mar 22, 2021
Test is reliable in sequential and not in parallel, so move it there. Fixes: #36627 PR-URL: #37842 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell removed the fast-track ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
Test is reliable in sequential and not in parallel, so move it there. Fixes: #36627 PR-URL: #37842 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos pushed a commit that referenced this pull request May 1, 2021
Test is reliable in sequential and not in parallel, so move it there. Fixes: #36627 PR-URL: #37842 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test is reliable in sequential and not in parallel, so move it there.
Fixes: #36627