deps: v8 backport 9689b17687b#37865
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
Member
targos commented Mar 22, 2021
Please add |
Member
targos commented Mar 22, 2021
Note to whoever lands this: the embedder string should be incremented. |
targos approved these changes Mar 22, 2021
Contributor
aduh95 commented Mar 22, 2021
This is targeting |
Member
targos commented Mar 23, 2021
|
Collaborator
nodejs-github-bot commented Mar 24, 2021
Collaborator
nodejs-github-bot commented Mar 25, 2021
ContributorAuthor
guybedford commented Mar 25, 2021
It would be great to get another approval here to land this TLA bug fix for 14.x. |
Collaborator
nodejs-github-bot commented Mar 29, 2021
ContributorAuthor
guybedford commented Mar 29, 2021
Switched the branch to rerun CI on 14.x-staging. Will land tomorrow. |
guybedford added a commit that referenced this pull request Mar 29, 2021
[top-level-await] Implement spec fix for cycle root detection Refs: http://github.com/v8/v8/commit/9689b17687b21c800c3f7400df4255c55b9c6ec0 PR-URL: #37865 Reviewed-By: Michaël Zasso <[email protected]>
ContributorAuthor
guybedford commented Mar 29, 2021
Landed in fe5e2e3. |
guybedford added a commit to guybedford/node that referenced this pull request Mar 30, 2021
[top-level-await] Implement spec fix for cycle root detection Refs: http://github.com/v8/v8/commit/9689b17687b21c800c3f7400df4255c55b9c6ec0 PR-URL: nodejs#37865 Reviewed-By: Michaël Zasso <[email protected]>
ruyadorno pushed a commit that referenced this pull request Mar 31, 2021
[top-level-await] Implement spec fix for cycle root detection Refs: http://github.com/v8/v8/commit/9689b17687b21c800c3f7400df4255c55b9c6ec0 PR-URL: #37865 Backport-PR-URL: #37985 Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 6, 2021
[top-level-await] Implement spec fix for cycle root detection Refs: http://github.com/v8/v8/commit/9689b17687b21c800c3f7400df4255c55b9c6ec0 PR-URL: #37865 Reviewed-By: Michaël Zasso <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit from https://chromium-review.googlesource.com/c/v8/v8/+/2667772, fixing a TLA execution ordering spec bug: