src: document newer values for --unhandled-rejections flag#37899
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
aduh95 reviewed Mar 25, 2021
Uh oh!
There was an error while loading. Please reload this page.
addaleax approved these changes Mar 25, 2021
ContributorAuthor
glasser commented Mar 25, 2021
I can make that change though for consistency with the rest of the options it would be better as |
glasserforce-pushed the unhandled-rejections-help branch from b189d4d to ef5f429CompareContributorAuthor
glasser commented Mar 25, 2021
Updated to put the default at the end. It uses a similar styling to other entries, though I don't see other entries that have another parenthesized thing right before the |
aduh95 approved these changes Mar 25, 2021
aduh95 added author ready ContributorAuthor
glasser commented Mar 25, 2021
By the way, I noticed that the indentation of wrapped help text looks strange and have filed #37911 to resolve. |
RaisinTen approved these changes Mar 26, 2021
Collaborator
nodejs-github-bot commented Mar 27, 2021
jasnell approved these changes Mar 27, 2021
These values were added in v15.0.0 by nodejs#33475 but were not included in the `node --help` output. Also documents which value is the default. PR-URL: nodejs#37899Fixes: nodejs#37896 Refs: nodejs#33475 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95force-pushed the unhandled-rejections-help branch from ef5f429 to ce6d756Compare
Contributor
aduh95 commented Mar 28, 2021
Landed in ce6d756 |
ruyadorno pushed a commit that referenced this pull request Mar 29, 2021
These values were added in v15.0.0 by #33475 but were not included in the `node --help` output. Also documents which value is the default. PR-URL: #37899Fixes: #37896 Refs: #33475 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this pull request Mar 30, 2021
These values were added in v15.0.0 by #33475 but were not included in the `node --help` output. Also documents which value is the default. PR-URL: #37899Fixes: #37896 Refs: #33475 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos pushed a commit that referenced this pull request May 1, 2021
These values were added in v15.0.0 by #33475 but were not included in the `node --help` output. Also documents which value is the default. PR-URL: #37899Fixes: #37896 Refs: #33475 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These values were added in v15.0.0 by #33475 but were not included in the
node --helpoutput.Also document which value is the default.
Fixes: #37896