test: fix flaky test-net-timeout#38060
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The check for an 800ms window makesw assumptions about a setTimeout() not running late etc. Remove it. Refs: nodejs#34289
nodejs-github-bot added needs-ci 
Trott added the flaky-test 
MemberAuthor
Trott commented Apr 3, 2021
lpinca approved these changes Apr 3, 2021
juanarbol approved these changes Apr 3, 2021
cjihrig approved these changes Apr 3, 2021
Collaborator
nodejs-github-bot commented Apr 6, 2021
marsonya added the author ready 
jasnell approved these changes Apr 6, 2021
Collaborator
nodejs-github-bot commented Apr 6, 2021
Member
jasnell commented Apr 6, 2021
Landed in 8b05e32 |
jasnell pushed a commit that referenced this pull request Apr 6, 2021
The check for an 800ms window makesw assumptions about a setTimeout() not running late etc. Remove it. Refs: #34289 PR-URL: #38060 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
The check for an 800ms window makesw assumptions about a setTimeout() not running late etc. Remove it. Refs: #34289 PR-URL: #38060 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check for an 800ms window makes assumptions about a setTimeout()
not running late etc. Remove it.
Refs: #34289