tools: relax max-len lint rule for template strings#38097
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added lib / src 
marsonya approved these changes Apr 5, 2021
aduh95 approved these changes Apr 5, 2021
BridgeAR approved these changes Apr 5, 2021
cjihrig approved these changes Apr 6, 2021
RaisinTen approved these changes Apr 6, 2021
This comment has been minimized.
This comment has been minimized.
RaisinTen added the author ready 
jasnell approved these changes Apr 6, 2021
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
Reluctant +1 .... I dislike both the long lines and having to split the template literals to wrap them.
Collaborator
Member
jasnell commented Apr 6, 2021
There's really no reason to make this wait the full 48 hours. Please 👍🏻 to fast-track |
jasnell added fast-track 
Splitting template strings across multiple lines can make them harder to read. PR-URL: nodejs#38097 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
Trott commented Apr 7, 2021
Landed in 038608d |
targos pushed a commit that referenced this pull request Sep 4, 2021
Splitting template strings across multiple lines can make them harder to read. PR-URL: #38097 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting template strings across multiple lines can make them harder to
read.