crypto: fix crash in CCM mode without data#38102
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
cjihrig approved these changes Apr 6, 2021
This comment has been minimized.
This comment has been minimized.
addaleax approved these changes Apr 6, 2021
jasnell approved these changes Apr 6, 2021
This comment has been minimized.
This comment has been minimized.
jasnell added the author ready This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
richardlau commented Apr 7, 2021
We've only just enabled testing against a dynamically linked OpenSSL 3 (nodejs/build#2584). The |
MemberAuthor
tniessen commented Apr 7, 2021
@richardlau Right, seems like the error code needs to be conditional here as well... (I guess that also means that we cannot upgrade to OpenSSL 3 in a semver-minor release.) |
Collaborator
nodejs-github-bot commented Apr 8, 2021
tniessen added a commit that referenced this pull request Apr 8, 2021
Fixes: #38035 PR-URL: #38102 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
tniessen commented Apr 8, 2021
Landed in dfe3f95, thanks for reviewing. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL requires calling the update function exactly once in CCM mode, and
EVP_CTRL_AEAD_GET_TAGwill fail if that doesn't happen. We do protect against calling the update function too many times, but calling it zero times isn't really a valid use case, so we never checked that.Fixes: #38035