lib: fix typo in lib/_tls_common.js#38129
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
aduh95 approved these changes Apr 7, 2021
aduh95 added author ready 
Contributor
aduh95 commented Apr 7, 2021
There's no reason to make this one wait the 48 hours to land. Collaborators, please 👍🏻 to fast-track |
lpinca approved these changes Apr 7, 2021
This comment has been minimized.
This comment has been minimized.
richardlau approved these changes Apr 7, 2021
RaisinTen approved these changes Apr 7, 2021
jasnell approved these changes Apr 7, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Apr 7, 2021
cjihrig approved these changes Apr 8, 2021
VoltrexKeyva approved these changes Apr 8, 2021
`byteLenth` -> `byteLength`. PR-URL: nodejs#38129 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Contributor
aduh95 commented Apr 8, 2021
Landed in b16e79e |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a typo : "byteLenth" -> "byteLength"