Skip to content

crypto: fixup randomFill size and offset handling#38138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jasnell wants to merge 3 commits into from
Closed

crypto: fixup randomFill size and offset handling #38138

jasnell wants to merge 3 commits into from

Conversation

@jasnell
Copy link
Member

@jasnelljasnell commented Apr 7, 2021

Fixes: #38137

Signed-off-by: James M Snell [email protected]

@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 7, 2021
@jasnelljasnell mentioned this pull request Apr 7, 2021
Closed
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@jasnelljasnellforce-pushed the fixup-randomfill-size branch from 023bb27 to b394ef2CompareApril 7, 2021 18:31
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 7, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/37258/

addaleax
addaleax reviewed Apr 7, 2021
View reviewed changes
Copy link
Member

@addaleaxaddaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this LGTM in the sense that it makes the code work correctly now, but I’m not really eager to click “approve” given how hard to understand this code is (Functions whose names start with assert that silently use different units for input and output? I think we can do better…)

@jasnell
Copy link
MemberAuthor

jasnell commented Apr 7, 2021

that silently use different units for input and output? I think we can do better…)

Agreed. I left these as is during the refactor and didn't like the way these were implemented then and still don't. It'll be good to refactor these next but let's address the immediate bug first.

addaleax
addaleax approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@addaleaxaddaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s at least leave a comment about why this is so confusing

@arkeronearkerone mentioned this pull request Apr 8, 2021
Closed
@jasnell@addaleax
[Squash] nit
1e91615
Co-authored-by: Anna Henningsen <[email protected]>
@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 8, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 8, 2021•
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37298/ 💚

RaisinTen
RaisinTen reviewed Apr 8, 2021
View reviewed changes
@jasnell@RaisinTen
[Squash] nit
4643682
Co-authored-by: Darshan Sen <[email protected]>
@jasnelljasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 8, 2021
@jasnell
Copy link
MemberAuthor

jasnell commented Apr 8, 2021

CI is green on this and it fixes a bug. There's no reason to make it wait the full 48 hours. Please 👍🏻 to fast track

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 9, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/37331/

jasnell added a commit that referenced this pull request Apr 9, 2021
@jasnell
crypto: fixup randomFill size and offset handling
d2f116c
Signed-off-by: James M Snell <[email protected]> PR-URL: #38138Fixes: #38137 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@jasnell
Copy link
MemberAuthor

jasnell commented Apr 9, 2021

Landed in d2f116c

@jasnelljasnell closed this Apr 9, 2021
@BethGriggsBethGriggs mentioned this pull request Apr 12, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@tniessentniessentniessen approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crypto.randomFill : error with TypedArray

8 participants

@jasnell@nodejs-github-bot@Trott@addaleax@lpinca@tniessen@RaisinTen@targos