doc: add link to V8#38144
Closed
doc: add link to V8 #38144
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Added the link redirecting to the V8 engine github repository just like libuv.
nodejs-github-bot added addons V8 should be above Worker.
gengjiawen approved these changes Apr 8, 2021
jasnell approved these changes Apr 8, 2021
RaisinTen approved these changes Apr 8, 2021
RaisinTen added the author ready Uh oh!
There was an error while loading. Please reload this page.
V8 redirect URL should redirect to the google source original domain instead of the mirror.
richardlau approved these changes Apr 8, 2021
addaleax approved these changes Apr 8, 2021
cjihrig approved these changes Apr 9, 2021
marsonya approved these changes Apr 9, 2021
RaisinTen pushed a commit that referenced this pull request Apr 10, 2021
Added the link redirecting to the V8 engine github repository just like libuv. PR-URL: #38144 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
RaisinTen commented Apr 10, 2021
Landed in 6a2314a |
targos pushed a commit that referenced this pull request May 1, 2021
Added the link redirecting to the V8 engine github repository just like libuv. PR-URL: #38144 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
Added the link redirecting to the V8 engine github repository just like libuv. PR-URL: #38144 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the link redirecting to the V8 engine main domain just like libuv.