deps: update llhttp to 5.1.0#38146
Closed
deps: update llhttp to 5.1.0 #38146
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added lib / src 
mcollina approved these changes Apr 8, 2021
Member
mcollina left a comment
mcollina left a comment There was a problem hiding this comment.
lgtm
Should this be backported?
Collaborator
nodejs-github-bot commented Apr 8, 2021
ronag approved these changes Apr 8, 2021
dnlup approved these changes Apr 8, 2021
Collaborator
nodejs-github-bot commented Apr 8, 2021
MemberAuthor
indutny commented Apr 8, 2021
@mcollina possibly, but I the |
Member
mcollina commented Apr 8, 2021
I've added a bunch of don't land labels to match this. |
mcollina added the semver-minor 
gengjiawen approved these changes Apr 9, 2021
gengjiawen added the author ready MemberAuthor
indutny commented Apr 10, 2021
Landed in 6a1986d. Thank you! |
indutny added a commit that referenced this pull request Apr 10, 2021
PR-URL: #38146 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniele Belardi <[email protected]>
Member
richardlau commented Apr 16, 2021
It looks like this has broken the tests for |
denihs pushed a commit to meteor/node-v14-esm that referenced this pull request Jun 28, 2023
PR-URL: nodejs#38146 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniele Belardi <[email protected]> # Conflicts: # deps/llhttp/README.md # deps/llhttp/include/llhttp.h # deps/llhttp/src/llhttp.c
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @nodejs/http @nodejs/http2 Note that handling of h2 preamble has changed and llhttp now returns HPE_PAUSED_H2_UPGRADE error.