test: update OpenSSL 3.x expected error message#38164
Merged
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
richardlau approved these changes Apr 9, 2021
Member
richardlau commented Apr 9, 2021
This started failing with OpenSSL 3 alpha 14 (nodejs/build#2613 (comment)). 👍 to fast track to unbreak the CI. |
Collaborator
nodejs-github-bot commented Apr 9, 2021
ContributorAuthor
danbev commented Apr 9, 2021
The failure in node-test-linux-linked-openssl300 is expected and should be fixed by #38165. |
Trott approved these changes Apr 9, 2021
Collaborator
nodejs-github-bot commented Apr 9, 2021
Member
Trott commented Apr 9, 2021
That PR has landed so now we should be able to get a green CI.... |
Trott added the author ready Collaborator
nodejs-github-bot commented Apr 9, 2021
Collaborator
nodejs-github-bot commented Apr 9, 2021
This commit updates an expected error message which has changed in OpenSSl 3.x. OpenSSL 3.0 is still under development but once there is a relase we should not be seeing test failure like this. PR-URL: nodejs#38164 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
aduh95force-pushed the openssl_test_crypto_dh_error_msg branch from d198e20 to 7216eb6Compare
Contributor
aduh95 commented Apr 9, 2021
Landed in 7216eb6 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates an expected error message which has changed in
OpenSSl 3.x. OpenSSL 3.0 is still under development but once there is a
relase we should not be seeing test failure like this.