doc: Update BUILDING.md for Apple Silicon#38227
Closed
+11 −10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added build 
aduh95 added arm 
Contributor
aduh95 commented Apr 13, 2021
Does this need to be backported to v14.x and v15.x? |
MemberAuthor
No we dont release for Apple silicon on those lines |
richardlau approved these changes Apr 13, 2021
BethGriggs approved these changes Apr 13, 2021
targos approved these changes Apr 13, 2021
BethGriggs added the fast-track 
Member
BethGriggs commented Apr 13, 2021
Fast-track? |
Trott approved these changes Apr 13, 2021
gengjiawen approved these changes Apr 14, 2021
Uh oh!
There was an error while loading. Please reload this page.
AshCrippsforce-pushed the update-building-md branch from f12e260 to 5b74f10CompareAshCripps pushed a commit that referenced this pull request Apr 14, 2021
PR-URL: #38227 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
MemberAuthor
AshCripps commented Apr 14, 2021
Landed in 98c2067 |
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
PR-URL: #38227 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update BUILDING.md to be correct for Apple Silicon for
16.x