Skip to content

Conversation

@arkerone
Copy link
Contributor

I found a typo in REPL documentation :

entires -> entries

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem. labels Apr 15, 2021
Copy link
Member

@jasnelljasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast track? Please 👍🏻

@jasnelljasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 15, 2021
@jasnell
Copy link
Member

Unrelated flaky failure in github CI... will land once I can get a good run.

@marsonyamarsonya added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 16, 2021
"entires" -> "entries" PR-URL: nodejs#38244 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@aduh95
Copy link
Contributor

Landed in e541032

@aduh95aduh95 merged commit e541032 into nodejs:masterApr 17, 2021
@arkeronearkerone deleted the doc/fix-typo-repl branch April 21, 2021 08:33
targos pushed a commit that referenced this pull request May 1, 2021
"entires" -> "entries" PR-URL: #38244 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
danielleadams pushed a commit that referenced this pull request May 8, 2021
"entires" -> "entries" PR-URL: #38244 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.replIssues and PRs related to the REPL subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

12 participants

@arkerone@jasnell@aduh95@Trott@lpinca@targos@cjihrig@richardlau@marsonya@RaisinTen@VoltrexKeyva@nodejs-github-bot