deps: patch V8 to 9.0.257.24#38423
Closed
deps: patch V8 to 9.0.257.24 #38423
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actionsbot added needs-ci 
This comment has been minimized.
This comment has been minimized.
cjihrig approved these changes Apr 27, 2021
jasnell approved these changes Apr 27, 2021
This comment has been minimized.
This comment has been minimized.
Collaborator
targos added the author ready 
Member
jasnell commented Apr 28, 2021
Landed in 8b60369 |
jasnell pushed a commit that referenced this pull request Apr 28, 2021
Refs: v8/v8@9.0.257.21...9.0.257.24 PR-URL: #38423 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Apr 29, 2021
Refs: v8/v8@9.0.257.21...9.0.257.24 PR-URL: #38423 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
zsims commented May 11, 2021
@targos when will this land in a v14 LTS release? Per https://github.com/nodejs/Release there should be a minor semver patch? |
Contributor
tchetwin commented May 12, 2021
zsims commented May 12, 2021
@tchetwin Exactly what I'm looking for. Thanks for your work on this + the release :-) |
zsims commented May 12, 2021
@tchetwin I would have expected to see v8/v8@df40e08 (as in this PR). Will this be making it to v14 LTS? |
zsims commented May 25, 2021
@tchetwin any updates for when/if v8/v8@df40e08 (in this PR) will land in v14 LTS? |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@9.0.257.21...9.0.257.24