test: fix flaky inspector-cli tests when breakpoints are restored

[Trott]

Sometimes, there isn't a newine in the AIX output that already has a
comment indicating it needs investigation.

[Trott]

Refs: https://ci.nodejs.org/job/node-test-commit-aix/36437/nodes=aix72-ppc64/console

00:30:58 not ok 3190 inspector-cli/test-inspector-cli-pid 00:31:08 --- 00:31:08 duration_ms: 10.872 00:31:08 severity: fail 00:31:09 exitcode: 1 00:31:09 stack: |- 00:31:09 node:internal/process/promises:246 00:31:09 triggerUncaughtException(err, true /* fromPromise */); 00:31:09 ^ 00:31:09 00:31:09 AssertionError [ERR_ASSERTION]: ifError got unwanted exception: Timeout (10000) while waiting for />\s+(?:\n1 breakpoints restored\.)?$/; found: Warning: script 'alive.js' was not loaded yet. 00:31:09 debug> 00:31:09 break in test/fixtures/inspector-cli/alive.js:3 00:31:09 1 let x = 0; 00:31:09 2 function heartbeat(){00:31:09 > 3 ++x; 00:31:09 4 } 00:31:09 5 setInterval(heartbeat, 50); 00:31:09 debug> 1 breakpoints restored. 00:31:09 00:31:09 at Timeout.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/common/inspector-cli.js:84:18) 00:31:09 at listOnTimeout (node:internal/timers:557:17) 00:31:09 at processTimers (node:internal/timers:500:7){00:31:09 generatedMessage: false, 00:31:09 code: 'ERR_ASSERTION', 00:31:09 actual: Error: Timeout (10000) while waiting for />\s+(?:\n1 breakpoints restored\.)?$/; found: Warning: script 'alive.js' was not loaded yet. 00:31:09 debug> 00:31:09 break in test/fixtures/inspector-cli/alive.js:3 00:31:09 1 let x = 0; 00:31:09 2 function heartbeat(){00:31:09 > 3 ++x; 00:31:09 4 } 00:31:09 5 setInterval(heartbeat, 50); 00:31:09 debug> 1 breakpoints restored. 00:31:09 00:31:09 at Timeout.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/common/inspector-cli.js:84:18) 00:31:09 at listOnTimeout (node:internal/timers:557:17) 00:31:09 at processTimers (node:internal/timers:500:7), 00:31:09 expected: null, 00:31:09 operator: 'ifError' 00:31:09 } 00:31:09 ... 

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37750/

[RaisinTen]

Suggested change

	// What we're diong for now:
	// What we're doing for now:

nit: typo from an earlier change

[richardlau]

Is there perhaps some deeper underlying issue with the inspector-cli tests?
Today's daily failed in inspector_cli_test_inspector_cli_address: https://ci.nodejs.org/job/node-test-commit-aix/36460/nodes=aix72-ppc64/testReport/junit/(root)/test/inspector_cli_test_inspector_cli_address/

[Trott]

Is there perhaps some deeper underlying issue with the inspector-cli tests?
Today's daily failed in inspector_cli_test_inspector_cli_address: https://ci.nodejs.org/job/node-test-commit-aix/36460/nodes=aix72-ppc64/testReport/junit/(root)/test/inspector_cli_test_inspector_cli_address/

Yeah, I think it's all one issue that:

• Should be addressed in waitPrompt() in test/common/inspector-cli.js rather than done piecemeal throughout the files. I'll look at opening a PR to do that.
• Doesn't really affect end users and might not even really be considered a bug. I'm guessing it has to do with buffering output somewhere.

I've been wondering if it makes sense to differentiate stdout and stderr in the debugger. The prompt should go to stdout, I imagine, but the warning messages should go to stderr perhaps. If we then keep them separate in the tests, it should be easy to make them robust.

[Trott]

OK, I've generalized the workaround. PTAL

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37791/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37804/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37890/

[Trott]

Landed in 18e4f40

[richardlau]

This didn't seem to be included in #38858 but does cherry-pick cleanly across to v14.x-staging after that landed.