test: fix common.mustCalllength and name properties#38464
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actionsbot added needs-ci 
jasnell approved these changes Apr 29, 2021
aduh95 added the author ready 
This comment has been minimized.
This comment has been minimized.
trivikr approved these changes Apr 30, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
jasnell added fast-track 
Contributor
Fast-track has been requested by @jasnell. Please 👍 to approve. |
Trott reviewed May 2, 2021
Uh oh!
There was an error while loading. Please reload this page.
Trott approved these changes May 2, 2021
Reassign `name` and `length` properties to the returned function to not break code that relies on it. PR-URL: nodejs#38464 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
aduh95force-pushed the test-common-mustCall-length branch from 92b358a to 5cee7cbCompareContributorAuthor
aduh95 commented May 2, 2021
Landed in 5cee7cb |
targos pushed a commit that referenced this pull request May 3, 2021
Reassign `name` and `length` properties to the returned function to not break code that relies on it. PR-URL: #38464 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
Reassign `name` and `length` properties to the returned function to not break code that relies on it. PR-URL: #38464 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
Reassign `name` and `length` properties to the returned function to not break code that relies on it. PR-URL: #38464 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
Reassign `name` and `length` properties to the returned function to not break code that relies on it. PR-URL: #38464 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
Reassign `name` and `length` properties to the returned function to not break code that relies on it. PR-URL: #38464 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reassign
nameandlengthproperties to the returned function to notbreak code that relies on it.
This is needed for #37947.