debugger: fixes to bring things closer to lint compatibility#38529
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Wrap lines more than 80 chararcters long in inspect_repl.js so we can disable specific rules.
Avoid non-ASCII char in lib code as a single non-ASCII char forces all the chars to be stored inefficiently, bloating the binary size. This also brings the file closer to compatibility with our lint rules.
github-actionsbot added inspector 
aduh95 approved these changes May 4, 2021
Uh oh!
There was an error while loading. Please reload this page.
Contributor
aduh95 commented May 4, 2021
For info, I have a PR almost ready to integrate primordials to that file :) |
cjihrig approved these changes May 4, 2021
Collaborator
nodejs-github-bot commented May 6, 2021
aduh95 approved these changes May 6, 2021
aduh95 added the author ready 
jasnell approved these changes May 6, 2021
Member
jasnell commented May 6, 2021
Landed in 75073ab...7eb28e3 |
jasnell pushed a commit that referenced this pull request May 6, 2021
Wrap lines more than 80 chararcters long in inspect_repl.js so we can disable specific rules. PR-URL: #38529 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request May 6, 2021
Avoid non-ASCII char in lib code as a single non-ASCII char forces all the chars to be stored inefficiently, bloating the binary size. This also brings the file closer to compatibility with our lint rules. PR-URL: #38529 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request May 6, 2021
PR-URL: #38529 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 17, 2021
Wrap lines more than 80 chararcters long in inspect_repl.js so we can disable specific rules. PR-URL: #38529 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 17, 2021
Avoid non-ASCII char in lib code as a single non-ASCII char forces all the chars to be stored inefficiently, bloating the binary size. This also brings the file closer to compatibility with our lint rules. PR-URL: #38529 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 17, 2021
PR-URL: #38529 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 19, 2021
Wrap lines more than 80 chararcters long in inspect_repl.js so we can disable specific rules. PR-URL: nodejs#38529 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 19, 2021
Avoid non-ASCII char in lib code as a single non-ASCII char forces all the chars to be stored inefficiently, bloating the binary size. This also brings the file closer to compatibility with our lint rules. PR-URL: nodejs#38529 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 19, 2021
PR-URL: nodejs#38529 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
richardlau commented Jul 19, 2021
Backport to v14.x PR: #39446 |
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
Wrap lines more than 80 chararcters long in inspect_repl.js so we can disable specific rules. PR-URL: nodejs#38529 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
Avoid non-ASCII char in lib code as a single non-ASCII char forces all the chars to be stored inefficiently, bloating the binary size. This also brings the file closer to compatibility with our lint rules. PR-URL: nodejs#38529 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
PR-URL: nodejs#38529 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
Wrap lines more than 80 chararcters long in inspect_repl.js so we can disable specific rules. PR-URL: nodejs#38529 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
Avoid non-ASCII char in lib code as a single non-ASCII char forces all the chars to be stored inefficiently, bloating the binary size. This also brings the file closer to compatibility with our lint rules. PR-URL: nodejs#38529 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 20, 2021
PR-URL: nodejs#38529 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
Wrap lines more than 80 chararcters long in inspect_repl.js so we can disable specific rules. PR-URL: #38529 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
Avoid non-ASCII char in lib code as a single non-ASCII char forces all the chars to be stored inefficiently, bloating the binary size. This also brings the file closer to compatibility with our lint rules. PR-URL: #38529 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
PR-URL: #38529 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
Wrap lines more than 80 chararcters long in inspect_repl.js so we can disable specific rules. PR-URL: #38529 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
Avoid non-ASCII char in lib code as a single non-ASCII char forces all the chars to be stored inefficiently, bloating the binary size. This also brings the file closer to compatibility with our lint rules. PR-URL: #38529 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
PR-URL: #38529 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
Wrap lines more than 80 chararcters long in inspect_repl.js so we can disable specific rules. PR-URL: nodejs#38529 Backport-PR-URL: nodejs#39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
Avoid non-ASCII char in lib code as a single non-ASCII char forces all the chars to be stored inefficiently, bloating the binary size. This also brings the file closer to compatibility with our lint rules. PR-URL: nodejs#38529 Backport-PR-URL: nodejs#39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
PR-URL: nodejs#38529 Backport-PR-URL: nodejs#39446 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.