test: improve coverage of lib/events.js#38582
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actionsbot added needs-ci 
jasnell approved these changes May 7, 2021
Collaborator
nodejs-github-bot commented May 7, 2021
Trott approved these changes May 8, 2021
Lxxyx added request-ci 
Lxxyx approved these changes Jun 10, 2021
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jun 10, 2021
Lxxyx added author ready github-actionsbot removed the commit-queue 
Contributor
Landed in bf2473d...a596fdf |
nodejs-github-bot pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #38582 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #38582 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Merged
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
PR-URL: #38582 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
PR-URL: #38582 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
PR-URL: #38582 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
PR-URL: nodejs#38582 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also rename the file (
eventtoevents) to keep consistant with other test files.