Skip to content

dgram: remove unreachable connectState assign#38590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jan 20, 2022
Merged

dgram: remove unreachable connectState assign #38590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions lib/dgram.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -186,9 +186,6 @@ function replaceHandle(self, newHandle){
// Replace the existing handle by the handle we got from primary.
oldHandle.close();
state.handle = newHandle;
// Check if the udp handle was connected and set the state accordingly
if (isConnected(self))
state.connectState = CONNECT_STATE_CONNECTED;
}

function bufferSize(self, size, buffer){
Expand DownExpand Up@@ -292,10 +289,6 @@ Socket.prototype.bind = function(port_, address_ /* , callback */){
if (err)
throw errnoException(err, 'open');

// Check if the udp handle was connected and set the state accordingly
if (isConnected(this))
state.connectState = CONNECT_STATE_CONNECTED;

startListening(this);
return this;
}
Expand DownExpand Up@@ -553,16 +546,6 @@ function clearQueue(){
queueEntry();
}

function isConnected(self){
try{
self.remoteAddress();
return true;
} catch{
return false;
}
}


// valid combinations
// For connectionless sockets
// send(buffer, offset, length, port, address, callback)
Expand Down