src: remove deadcode in node_file.cc#38693
Closed
+0 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actionsbot added c++ 
addaleax approved these changes May 15, 2021
RaisinTen approved these changes May 15, 2021
This comment has been minimized.
This comment has been minimized.
RaisinTen added the author ready 
cjihrig approved these changes May 15, 2021
Contributor
cjihrig left a comment
cjihrig left a comment There was a problem hiding this comment.
LGTM, but I'd refer to it as commented out code in the commit message.
lpinca approved these changes May 15, 2021
Trott approved these changes May 16, 2021
This comment has been minimized.
This comment has been minimized.
The implementation of the `fs.lchmod` method has been moved to JS-land
juanarbolforce-pushed the juan/remove-cc-deadcode branch from 7d814c9 to b0722e7Compare This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell approved these changes May 17, 2021
This comment has been minimized.
This comment has been minimized.
antsmartian approved these changes May 19, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Member
jasnell commented May 21, 2021
Landed in c9269a4 |
jasnell pushed a commit that referenced this pull request May 21, 2021
The implementation of the `fs.lchmod` method has been moved to JS-land PR-URL: #38693 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
danielleadams pushed a commit that referenced this pull request May 31, 2021
The implementation of the `fs.lchmod` method has been moved to JS-land PR-URL: #38693 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
The implementation of the `fs.lchmod` method has been moved to JS-land PR-URL: #38693 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
The implementation of the `fs.lchmod` method has been moved to JS-land PR-URL: #38693 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
The implementation of the `fs.lchmod` method has been moved to JS-land PR-URL: #38693 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
The implementation of the `fs.lchmod` method has been moved to JS-land PR-URL: nodejs#38693 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of the
fs.lchmodmethod has been moved to JS-land