src: remove unused iostream library#38694
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actionsbot added c++ 
addaleax approved these changes May 15, 2021
Member
RaisinTen commented May 15, 2021
Should we remove this too? Line 7 in 4a22850 |
Member
addaleax commented May 15, 2021
@RaisinTen yes 👍 |
cjihrig approved these changes May 15, 2021
lpinca approved these changes May 15, 2021
Remove unused `iostream` library in `node_main_instance.cc` and `aliased_buffer.h` files
juanarbolforce-pushed the juan/remove-iostream branch from fc7085e to 8abe5bcComparejuanarbol added the author ready 
This comment has been minimized.
This comment has been minimized.
Trott approved these changes May 16, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
RaisinTen changed the title node_main_instance.cc fileiostream library
RaisinTen approved these changes May 17, 2021
jasnell approved these changes May 17, 2021
This comment has been minimized.
This comment has been minimized.
antsmartian approved these changes May 19, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented May 20, 2021
juanarbol added a commit that referenced this pull request May 20, 2021
Remove unused `iostream` library in `node_main_instance.cc` and `aliased_buffer.h` files PR-URL: #38694 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
MemberAuthor
juanarbol commented May 20, 2021
Landed in d7611ec <3 |
danielleadams pushed a commit that referenced this pull request May 31, 2021
Remove unused `iostream` library in `node_main_instance.cc` and `aliased_buffer.h` files PR-URL: #38694 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused
iostreamlibrary