lib: refactor to use optional chaining#38697
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This PR migrates expressions such as `a ? a.b : c` to `a?.b ?? c` Codemod script: https://github.com/pd4d10/nodejs-codemod/blob/main/src/optional-chaining.ts
aduh95 commented May 16, 2021
I'm not sure we want to do that after #38245... |
| getfd(){ | ||
| returnthis.#channel ? this.#channel.fd:undefined; | ||
| returnthis.#channel?.fd??undefined; |
There was a problem hiding this comment.
| returnthis.#channel?.fd??undefined; | |
| returnthis.#channel?.fd; |
| returnfalse; | ||
| constrequest=stream[kRequest]; | ||
| returnrequest ? request.readable:stream.readable; | ||
| returnrequest?.readable??stream.readable; |
There was a problem hiding this comment.
| returnrequest?.readable??stream.readable; | |
| returnstream[kRequest]?.readable??stream.readable; |
| functiondebugStreamObj(stream,message, ...args){ | ||
| constsession=stream[kSession]; | ||
| consttype=session ? session[kType] :undefined; | ||
| consttype=session?.kType??undefined; |
There was a problem hiding this comment.
| consttype=session?.kType??undefined; | |
| consttype=stream[kSession]?.[kType]; |
| functiononError(msg,err,callback){ | ||
| consttriggerAsyncId=msg.socket ? msg.socket[async_id_symbol]:undefined; | ||
| consttriggerAsyncId=msg.socket?.[async_id_symbol]??undefined; |
There was a problem hiding this comment.
| consttriggerAsyncId=msg.socket?.[async_id_symbol]??undefined; | |
| consttriggerAsyncId=msg.socket?.[async_id_symbol]; |
pd4d10 commented May 16, 2021
OK. Given this information, I guess we should hold it until the performance issues solved. |
Mifrill left a comment
Mifrill left a comment There was a problem hiding this comment.
Those changes look great, and I see the potential performance issue was also taken into consideration, that's awesome, however would like to raise a hand and ask if the chaining is slower than the ternary operator.
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
4 participants
This PR migrates expressions such as
a ? a.b : ctoa?.b ?? cCodemod script:
https://github.com/pd4d10/nodejs-codemod/blob/main/src/optional-chaining.ts
Also see:
#38609