Skip to content

stream: allow empty string as first stream of pipeline#38723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Ayase-252 wants to merge 2 commits into from
Closed

stream: allow empty string as first stream of pipeline #38723

Ayase-252 wants to merge 2 commits into from

Conversation

@Ayase-252
Copy link
Member

@Ayase-252Ayase-252 commented May 18, 2021•
edited
Loading

Empty string '' should be allowed as first stream of pipeline per doc as Iterable.

Fixes: #38721

aduh95
aduh95 approved these changes May 18, 2021
View reviewed changes
@Ayase-252@aduh95
fixup!: simplify test condition
a0fb263
Co-authored-by: Antoine du Hamel <[email protected]>
@Ayase-252Ayase-252 added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels May 19, 2021
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 19, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 19, 2021•
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/38190/ 🟢

@jasnelljasnell removed the needs-ci PRs that need a full CI run. label May 20, 2021
@jasnell
Copy link
Member

jasnell commented May 20, 2021

Landed in b9ef539

@jasnelljasnell closed this May 20, 2021
jasnell pushed a commit that referenced this pull request May 20, 2021
@Ayase-252@jasnell
stream: allow empty string as source of pipeline
b9ef539
Fixes: #38721 PR-URL: #38723 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@Ayase-252Ayase-252 deleted the fix/38721-stream branch May 21, 2021 14:15
danielleadams pushed a commit that referenced this pull request May 31, 2021
@Ayase-252@danielleadams
stream: allow empty string as source of pipeline
4131f94
Fixes: #38721 PR-URL: #38723 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@danielleadamsdanielleadams mentioned this pull request May 31, 2021
Merged
@richardlau
Copy link
Member

richardlau commented Jul 16, 2021

Depends on #37508

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@ronagronagronag approved these changes

@BridgeARBridgeARBridgeAR approved these changes

@LxxyxLxxyxLxxyx approved these changes

@aduh95aduh95aduh95 approved these changes

@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stream.pipeline does not accept zero-length string as a valid first argument

10 participants

@Ayase-252@nodejs-github-bot@jasnell@richardlau@lpinca@ronag@BridgeAR@Lxxyx@aduh95@RaisinTen