lib: support fs_event_wrap in the snapshot and load more modules eagerly#38737
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
So that they are included in the builtin snapshot
Now that more modules are included in the snapshot, it's not necessary to lazy load them anymore
github-actionsbot added lib / src 
joyeecheung changed the title 
Collaborator
nodejs-github-bot commented May 19, 2021
VoltrexKeyva approved these changes May 19, 2021
addaleax approved these changes May 19, 2021
Collaborator
nodejs-github-bot commented May 26, 2021
joyeecheung added a commit that referenced this pull request May 27, 2021
PR-URL: #38737 Refs: #35711 Reviewed-By: Anna Henningsen <[email protected]>
joyeecheung added a commit that referenced this pull request May 27, 2021
So that they are included in the builtin snapshot PR-URL: #38737 Refs: #35711 Reviewed-By: Anna Henningsen <[email protected]>
joyeecheung added a commit that referenced this pull request May 27, 2021
Now that more modules are included in the snapshot, it's not necessary to lazy load them anymore PR-URL: #38737 Refs: #35711 Reviewed-By: Anna Henningsen <[email protected]>
MemberAuthor
joyeecheung commented May 27, 2021
Landed in b6471c9...a4ea9fc |
danielleadams pushed a commit that referenced this pull request May 31, 2021
PR-URL: #38737 Refs: #35711 Reviewed-By: Anna Henningsen <[email protected]>
danielleadams pushed a commit that referenced this pull request May 31, 2021
So that they are included in the builtin snapshot PR-URL: #38737 Refs: #35711 Reviewed-By: Anna Henningsen <[email protected]>
danielleadams pushed a commit that referenced this pull request May 31, 2021
Now that more modules are included in the snapshot, it's not necessary to lazy load them anymore PR-URL: #38737 Refs: #35711 Reviewed-By: Anna Henningsen <[email protected]>
Merged
Member
richardlau commented Jul 16, 2021
Blocked on #32984. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we support more modules in the snapshot, it's no longer necessary to lazy load them for speeding up startup.
Refs: #35711