url: exit early when : delimiter is seen in hostname#38742
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actionsbot added c++ 
TimothyGu added the whatwg-url 
cjihrig approved these changes May 20, 2021
RaisinTen approved these changes May 20, 2021
This comment has been minimized.
This comment has been minimized.
RaisinTen added the author ready 
jasnell approved these changes May 20, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This aligns with an upstream spec change. Fixes: nodejs#38710
Collaborator
nodejs-github-bot commented May 21, 2021
MemberAuthor
TimothyGu commented May 21, 2021
Updated the WPT status file. Should hopefully work on without-intl builds now. |
Collaborator
nodejs-github-bot commented May 22, 2021
Collaborator
nodejs-github-bot commented May 23, 2021
TimothyGu added a commit that referenced this pull request May 23, 2021
This aligns with an upstream spec change. PR-URL: #38742Fixes: #38710 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
TimothyGu commented May 23, 2021
Landed in bf06daa. |
danielleadams pushed a commit that referenced this pull request May 31, 2021
This aligns with an upstream spec change. PR-URL: #38742Fixes: #38710 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Member
richardlau commented Jul 16, 2021
Does not land cleanly on v14.x-staging. |
Member
targos commented Jul 16, 2021
v14.x is missing a lot of URL and WPT commits. |
This was referenced Aug 21, 2021
Member
RaisinTen commented Aug 22, 2021
Reason behind marking this as |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns with an upstream spec change.
Fixes: #38710