test: remove unnecessary --pending-deprecation flag#38819
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actionsbot added needs-ci 
Collaborator
nodejs-github-bot commented May 26, 2021
RaisinTen approved these changes May 26, 2021
jasnell approved these changes May 26, 2021
aduh95 added the author ready Collaborator
nodejs-github-bot commented May 26, 2021
Trott approved these changes May 26, 2021
lpinca approved these changes May 28, 2021
bl-ue approved these changes May 28, 2021
Collaborator
nodejs-github-bot commented Jun 1, 2021
Collaborator
nodejs-github-bot commented Jun 1, 2021
Collaborator
nodejs-github-bot commented Jun 1, 2021
PR-URL: nodejs#38819 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95force-pushed the esm-exports-not-pending-deprecations branch from 7212173 to 26bf4f3CompareContributorAuthor
aduh95 commented Jun 1, 2021
Landed in 26bf4f3 |
danielleadams pushed a commit that referenced this pull request Jun 2, 2021
PR-URL: #38819 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those have been migrated to runtime deprecation in v16.0.0.