Skip to content

fixed typo in documentation (n-api.md)#38822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julianjany wants to merge 2 commits into from
Closed

fixed typo in documentation (n-api.md) #38822

julianjany wants to merge 2 commits into from

Conversation

@julianjany
Copy link
Contributor

@julianjanyjulianjany commented May 27, 2021•
edited
Loading

fixed typo in documentation (n-api.md):
Node-API -API

@github-actionsgithub-actionsbot added the doc Issues and PRs related to the documentations. label May 27, 2021
@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2021
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label May 27, 2021
@github-actions
Copy link
Contributor

github-actionsbot commented May 27, 2021

Fast-track has been requested by @Trott. Please 👍 to approve.

@Flarna
Copy link
Member

Flarna commented May 31, 2021

If I try to land this via git node land it tells Last GitHub CI failed which doesn't match to what I see here.

Any hint what's wrong here?

mhdawson
mhdawson approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejsnodejs deleted a comment from github-actionsbotMay 31, 2021
@Flarna
Copy link
Member

Flarna commented Jun 1, 2021

Landed in fc269b3

@FlarnaFlarna closed this Jun 1, 2021
Flarna pushed a commit that referenced this pull request Jun 1, 2021
@julianjany@Flarna
doc: fixed typo in n-api.md
fc269b3
PR-URL: #38822 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 1, 2021
@julianjany@danielleadams
doc: fixed typo in n-api.md
108ffdb
PR-URL: #38822 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jun 1, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@julianjany@richardlau
doc: fixed typo in n-api.md
8dcdddd
PR-URL: #38822 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@julianjany@richardlau
doc: fixed typo in n-api.md
1c164ba
PR-URL: #38822 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@julianjany@richardlau
doc: fixed typo in n-api.md
e36d2a6
PR-URL: #38822 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@richardlaurichardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@julianjany@foxxyz
doc: fixed typo in n-api.md
6d6dc03
PR-URL: nodejs#38822 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@TrottTrottTrott approved these changes

@lpincalpincalpinca approved these changes

@tniessentniessentniessen approved these changes

@richardlaurichardlaurichardlau approved these changes

@mhdawsonmhdawsonmhdawson approved these changes

@marsonyamarsonyamarsonya approved these changes

@FlarnaFlarnaFlarna approved these changes

@RaisinTenRaisinTenRaisinTen approved these changes

+1 more reviewer

@bl-uebl-uebl-ue approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@julianjany@Flarna@jasnell@Trott@lpinca@tniessen@richardlau@mhdawson@marsonya@RaisinTen@bl-ue