Skip to content

Conversation

@joyeecheung
Copy link
Member

@joyeecheungjoyeecheung commented May 27, 2021

Refs: #35711

@github-actionsgithub-actionsbot added needs-ci PRs that need a full CI run. url Issues and PRs related to the legacy built-in url module. labels May 27, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@joyeecheung
Copy link
MemberAuthor

It seems some tests fail with this, some tmp files weren't properly cleaned up after the test finished.

Can't clean tmpdir: /home/iojs/tmp/.tmp.261 Files blocking: [ '.nfs00000000019201330000031d' ] Note: ".nfs*" might be files that were open and unlinked but not closed. See http://nfs.sourceforge.net/#faq_d2 for details. /home/iojs/build/workspace/node-test-binary-arm/test/common/tmpdir.js:55 throw e; ^ Error: ENOTEMPTY: directory not empty, rmdir '/home/iojs/tmp/.tmp.261' at Object.rmdirSync (node:fs:1157:10) at _rmdirSync (node:internal/fs/rimraf:260:21) at rimrafSync (node:internal/fs/rimraf:193:7) at Object.rmSync (node:fs:1204:10) at rmSync (/home/iojs/build/workspace/node-test-binary-arm/test/common/tmpdir.js:9:6) at process.onexit (/home/iojs/build/workspace/node-test-binary-arm/test/common/tmpdir.js:40:5) at process.emit (node:events:406:35){errno: -39, syscall: 'rmdir', code: 'ENOTEMPTY', path: '/home/iojs/tmp/.tmp.261' } 

I can't see why this PR would result in a difference, is it a test util bug? @nodejs/testing

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@joyeecheungjoyeecheung removed the needs-ci PRs that need a full CI run. label Jun 2, 2021
joyeecheung added a commit that referenced this pull request Jun 2, 2021
PR-URL: #38826 Refs: #35711 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
@joyeecheung
Copy link
MemberAuthor

Landed in 2bb0c20

danielleadams pushed a commit that referenced this pull request Jun 2, 2021
PR-URL: #38826 Refs: #35711 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jun 2, 2021
@richardlau
Copy link
Member

This doesn't land cleanly on v14.x-staging.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

urlIssues and PRs related to the legacy built-in url module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@joyeecheung@nodejs-github-bot@richardlau@jasnell@targos@XadillaX@Apakottur