src: replace autos in node_api.cc#38852
Uh oh!
There was an error while loading. Please reload this page.
Conversation
github-actionsbot added c++ 
bl-ue left a comment
bl-ue left a comment There was a problem hiding this comment.
All looks good, but why not use auto, exactly?
XadillaX commented May 30, 2021
https://github.com/nodejs/node/blob/master/doc/guides/cpp-style-guide.md#using-auto |
Ah, makes perfect sense.
Those are points that I've thought about myself. Of course, when you're using an IDE, it'll tell you what |
| {0, 0}); | ||
| } else{ | ||
| auto node_async_context = | ||
| v8impl::AsyncContext* node_async_context = |
There was a problem hiding this comment.
By the way, I think the results of casts and new ... can qualify as “obvious” types. I don’t mind changing these, but I’d avoid doing it everywhere because of the churn it creates.
There was a problem hiding this comment.
I just consider that "Forget auto keywords in C++ except lambda".
nodejs-github-bot commented May 31, 2021
nodejs-github-bot commented May 31, 2021
mhdawson added the author ready 
PR-URL: #38852 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
XadillaX commented Jun 1, 2021
Landed in 46acbb0 |
PR-URL: #38852 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #38852 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #38852 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #38852 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs#38852 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
7 participants
No description provided.