Skip to content

build: export more OpenSSL symbols on Windows#38857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mscdex wants to merge 1 commit into
base:main
Choose a base branch
from
Open

build: export more OpenSSL symbols on Windows #38857

mscdex wants to merge 1 commit into from

Conversation

@mscdex
Copy link
Contributor

@mscdexmscdex commented May 30, 2021

No description provided.

@mscdexmscdex added the wip Issues and PRs that are still a work in progress. label May 30, 2021
@github-actionsgithub-actionsbot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 30, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@mscdexmscdexforce-pushed the win-export-more-symbols branch from ad7d02e to 4a902e3CompareMay 30, 2021 16:34
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@mscdexmscdexforce-pushed the win-export-more-symbols branch from 4a902e3 to e90bd5cCompareMay 30, 2021 17:26
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@mscdexmscdex added the build Issues and PRs related to build files or the CI. label May 30, 2021
@mscdexmscdex marked this pull request as ready for review May 30, 2021 17:26
@mscdexmscdex removed the wip Issues and PRs that are still a work in progress. label May 30, 2021
@mscdex
Copy link
ContributorAuthor

mscdex commented May 30, 2021•
edited
Loading

Getting a lot of unrelated EACCES failures for parallel/test-fs-rm on multiple platforms.... not sure what that's about.

EDIT: I'm guessing f9447b7 may be the culprit for that

@targos
Copy link
Member

targos commented Jul 11, 2021

@mscdex I think these issues will be fixed if you rebase.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@mscdexmscdexforce-pushed the win-export-more-symbols branch from e90bd5c to b049ea6CompareJuly 11, 2021 13:10
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 11, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38962/

@mscdexmscdex removed the needs-ci PRs that need a full CI run. label Jul 11, 2021
@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 12, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47881/

This was referenced Nov 13, 2022
Open
Open
Open
This was referenced Nov 16, 2022
Open
Open
@aduh95
Copy link
Contributor

aduh95 commented May 11, 2024

This needs a rebase

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

+1 more reviewer

@bl-uebl-uebl-ue approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

addonsIssues and PRs related to native addons.buildIssues and PRs related to build files or the CI.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mscdex@nodejs-github-bot@targos@aduh95@jasnell@addaleax@bl-ue