[v16.x backport] lib: make primordials Promise methods safe#38878
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actionsbot added fs 
bl-ue approved these changes Jun 1, 2021
`catch` and `finally` methods on %Promise.prototype% looks up the `then` property of the instance, making it at risk of prototype pollution. PR-URL: nodejs#38650 Refs: https://tc39.es/ecma262/#sec-promise.prototype.catch Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
theoludwig approved these changes Jun 10, 2021
Lxxyx approved these changes Jun 11, 2021
Lxxyx added request-ci github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jun 11, 2021
Collaborator
nodejs-github-bot commented Jun 13, 2021
danielleadams approved these changes Jun 13, 2021
targos pushed a commit that referenced this pull request Jun 14, 2021
`catch` and `finally` methods on %Promise.prototype% looks up the `then` property of the instance, making it at risk of prototype pollution. PR-URL: #38650 Backport-PR-URL: #38878 Refs: https://tc39.es/ecma262/#sec-promise.prototype.catch Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Member
targos commented Jun 14, 2021
Landed in ded8335 |
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
`catch` and `finally` methods on %Promise.prototype% looks up the `then` property of the instance, making it at risk of prototype pollution. PR-URL: #38650 Backport-PR-URL: #38878 Refs: https://tc39.es/ecma262/#sec-promise.prototype.catch Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
catchandfinallymethods on %Promise.prototype% looks up thethenproperty of the instance, making it at risk of prototype pollution.
PR-URL: #38650
Refs: https://tc39.es/ecma262/#sec-promise.prototype.catch
Reviewed-By: James M Snell [email protected]
Reviewed-By: Matteo Collina [email protected]