Skip to content

Conversation

@tniessen
Copy link
Member

No description provided.

@github-actionsgithub-actionsbot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Jun 2, 2021
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jun 2, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

Copy link
Contributor

@bl-uebl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't caught by the linter?

@LxxyxLxxyx added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2021
@github-actionsgithub-actionsbot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2021
@github-actions
Copy link
Contributor

Landed in a596fdf...76ebad0

nodejs-github-bot pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #38898 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #38898 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jun 14, 2021
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
PR-URL: #38898 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
@richardlau
Copy link
Member

Webcrypto is marked semver-major (#35093) so marking this as dont-land-on-v14.x.

@tniessentniessen deleted the doc-aesImportParams branch October 7, 2021 16:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@tniessen@richardlau@lpinca@cjihrig@Lxxyx@aduh95@RaisinTen@HarshithaKP@bl-ue