Skip to content

vm: use missing validator#38935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
VoltrexKeyva wants to merge 2 commits into from
Closed

vm: use missing validator #38935

VoltrexKeyva wants to merge 2 commits into from

Conversation

@VoltrexKeyva
Copy link
Member

@VoltrexKeyvaVoltrexKeyva commented Jun 4, 2021

The vm lib module's isContext() function should use a validator.

@VoltrexKeyva
vm: use missing validator
3550e92
The `vm` lib module's `isContext()` function should use a validator.
@github-actionsgithub-actionsbot added needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Jun 4, 2021
@VoltrexKeyva
fixup! vm: use missing validator
1f98445
Arrays are also passed to `isContext()` when used in the internals so its a good approach to allow arrays.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 5, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38499/

@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 5, 2021
jasnell pushed a commit that referenced this pull request Jun 7, 2021
@VoltrexKeyva@jasnell
vm: use missing validator
826566e
The `vm` lib module's `isContext()` function should use a validator. PR-URL: #38935 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jun 7, 2021

Landed in 826566e

@jasnelljasnell closed this Jun 7, 2021
@VoltrexKeyvaVoltrexKeyva deleted the patch-6 branch June 7, 2021 14:43
targos pushed a commit that referenced this pull request Jun 11, 2021
@VoltrexKeyva@targos
vm: use missing validator
f40725f
The `vm` lib module's `isContext()` function should use a validator. PR-URL: #38935 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jun 14, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@VoltrexKeyva@richardlau
vm: use missing validator
2f72ca5
The `vm` lib module's `isContext()` function should use a validator. PR-URL: #38935 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@VoltrexKeyva@richardlau
vm: use missing validator
31359e1
The `vm` lib module's `isContext()` function should use a validator. PR-URL: #38935 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@VoltrexKeyva@richardlau
vm: use missing validator
dd00547
The `vm` lib module's `isContext()` function should use a validator. PR-URL: #38935 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
@richardlaurichardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@VoltrexKeyva@foxxyz
vm: use missing validator
9d40558
The `vm` lib module's `isContext()` function should use a validator. PR-URL: nodejs#38935 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@LxxyxLxxyxLxxyx approved these changes

@RaisinTenRaisinTenRaisinTen approved these changes

+3 more reviewers

@devsnekdevsnekdevsnek approved these changes

@ycjcl868ycjcl868ycjcl868 approved these changes

@bl-uebl-uebl-ue approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@VoltrexKeyva@nodejs-github-bot@jasnell@addaleax@lpinca@devsnek@Lxxyx@ycjcl868@RaisinTen@bl-ue