Revert "build: work around bug in MSBuild v16.10.0"#38977
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reverts commit 3457130. Visual Studio v16.10.1 is out. Closes: nodejs#38872
github-actionsbot added build 
MemberAuthor
targos commented Jun 9, 2021
I do not expect this to work immediately on GitHub actions because they probably haven't updated yet. |
MemberAuthor
targos commented Jun 9, 2021
Confirmed it works on my computer: |
lpinca approved these changes Jun 9, 2021
cjihrig approved these changes Jun 11, 2021
jasnell approved these changes Jun 11, 2021
MemberAuthor
targos commented Jun 11, 2021
I think it will work after actions/runner-images#3554 is merged. |
Contributor
aduh95 commented Jun 14, 2021
This has been merged, I've restarted the Windows Actions to confirm the workaround is no longer necessary. |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jun 14, 2021
targos added the commit-queue github-actionsbot removed the commit-queue 
Contributor
Landed in 7a9635b...842554f |
nodejs-github-bot pushed a commit that referenced this pull request Jun 15, 2021
This reverts commit 3457130. Visual Studio v16.10.1 is out. Closes: #38872 PR-URL: #38977Fixes: #38872 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 21, 2021
This reverts commit 3457130. Visual Studio v16.10.1 is out. Closes: #38872 PR-URL: #38977Fixes: #38872 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
richardlau pushed a commit that referenced this pull request Jul 19, 2021
This reverts commit 3457130. Visual Studio v16.10.1 is out. Closes: #38872 PR-URL: #38977Fixes: #38872 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
This reverts commit 3457130. Visual Studio v16.10.1 is out. Closes: #38872 PR-URL: #38977Fixes: #38872 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
This reverts commit 3457130. Visual Studio v16.10.1 is out. Closes: nodejs#38872 PR-URL: nodejs#38977Fixes: nodejs#38872 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3457130.
Visual Studio v16.10.1 is out.
Closes: #38872